feat(metrics): Add integration with installation by SDK#6956
Merged
feat(metrics): Add integration with installation by SDK#6956
Conversation
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Tests/SentryTests/Integrations/Metrics/SentryMetricsIntegrationTests.swift
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6956 +/- ##
=============================================
+ Coverage 84.770% 84.826% +0.056%
=============================================
Files 461 462 +1
Lines 27860 27871 +11
Branches 12320 12333 +13
=============================================
+ Hits 23617 23642 +25
- Misses 3979 4188 +209
+ Partials 264 41 -223
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Member
Author
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Tests/SentryTests/Integrations/Metrics/SentryMetricsIntegrationTests.swift
Show resolved
Hide resolved
7 tasks
philprime
force-pushed
the
philprime/metrics-bootstrap
branch
from
a5056fb to
1210307
Compare
- Introduced new test file `SentryItemBatcherTests.swift` to validate the behavior of the `SentryItemBatcher`. - Added tests for various scenarios including item addition, buffer size limits, timeout handling, and attribute enrichment. - Updated project configuration to include the new test file in the build settings.
…lprime/metrics-bootstrap
Member
Author
|
After reconsideration and learnings while working on #6957 I decided that I will move this feature to be marked as "experimental" first to keep some leeway to react if the public API using Swift Language features such as ExpressibleByInt is not working as expected. |
Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift
Outdated
Show resolved
Hide resolved
philprime
added
the
dontmerge
9 tasks
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Member
Author
|
All PRs are now ready to be merged and approved. Starting stacked merge process |
philprime
added
Waiting for: CI 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a merge-chain and should be merged one-by-one into
mainas soon as all of them are ready to be merged:📜 Description
This pull request introduces a new metrics integration to the Sentry SDK for Swift, allowing users to enable metrics collection and reporting via the SDK. The changes include the addition of the
enableMetricsoption, implementation of the metrics integration, updates to the SDK configuration, and new tests to verify the integration. The project structure is also updated to include the new integration and its tests.Metrics Integration Feature:
enableMetricsoption toSentryOptions, allowing users to enable or disable metrics collection. [1] [2]MetricsIntegration, which is installed whenenableMetricsis set totrue. [1] [2]enableMetricsoption. [1] [2]💡 Motivation and Context
Closes #6954
💚 How did you test it?
enableLogs📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.